From: Junio C Hamano Date: Sun, 28 Jun 2026 05:10:46 GMT Subject: Re: [PATCH] http: accept https:// proxies again Message-ID: In-Reply-To: Junio C Hamano writes: > From this function nothing returns an error anymore, and looking at > the preimage of 663d7abe (http: reject unsupported proxy URL > schemes, 2026-05-05) that is the source of the bug, the original did > not do anything when the corresponding code did not find and set any > proxy settings, either. > > So perhaps it is a better fix to make it just a function that > returns void with early returns? Nah, I was being stupid. Disregard the above. The whole point of 663d7abe was that we wanted to reject what we did not recognise, and we cannot do so without returning "good/bad" from that function. The bug was that we did recognise https:// but still returned -1 because of the bug, which the patch in the thread fixed. Thanks.