From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Aug 2026 21:49:00 GMT
Subject: Re: [PATCH 1/3] environment: simplify repository config getters
Message-ID: <xmqqjyq4nsqb.fsf@gitster.g>
In-Reply-To: <20260805115342.3939931-2-cat@malon.dev>

Tian Yuchen <cat@malon.dev> writes:

> Drop unnecessary parentheses and NULL checks in repository config
> getters.
>
> These getters are only used with non-NULL repositories, so the
> extra checks do not match their current callers.

OK.  If repo MUST always be non-NULL, even when we haven't fully
initialized them, then not punting on repo==NULL case like the
original code is definitely an improvement.

Looking good.

>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
> Signed-off-by: Tian Yuchen <cat@malon.dev>
> ---
>  environment.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/environment.c b/environment.c
> index 76ee65e62b..f5628b6758 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -119,23 +119,23 @@ int is_bare_repository(struct repository *repo)
>  
>  int repo_protect_ntfs(struct repository *repo)
>  {
> -	return (repo && repo->initialized) ?
> -		repo_config_values(repo)->protect_ntfs :
> -		PROTECT_NTFS_DEFAULT;
> +	return repo->initialized
> +		? repo_config_values(repo)->protect_ntfs
> +		: PROTECT_NTFS_DEFAULT;
>  }
>  
>  int repo_protect_hfs(struct repository *repo)
>  {
> -	return (repo && repo->initialized) ?
> -		repo_config_values(repo)->protect_hfs :
> -		PROTECT_HFS_DEFAULT;
> +	return repo->initialized
> +		? repo_config_values(repo)->protect_hfs
> +		: PROTECT_HFS_DEFAULT;
>  }
>  
>  int repo_ignore_case(struct repository *repo)
>  {
> -	return (repo && repo->initialized) ?
> -		repo_config_values(repo)->ignore_case :
> -		0;
> +	return repo->initialized
> +		? repo_config_values(repo)->ignore_case
> +		: 0;
>  }
>  
>  int repo_trust_executable_bit(struct repository *repo)