From: Junio C Hamano Date: Thu, 15 Oct 2026 19:32:40 GMT Subject: Re: [PATCH v2 1/3] var: add GIT_HOSTNAME Message-ID: In-Reply-To: <20261015105859.3184108-2-bellacaselli20@gmail.com> Isabella Caselli writes: > Git asks the system for the name of the machine it runs on in a few > places. For example, "git gc" records it in "gc.pid" to tell whether > the gc holding the lock runs on the same machine. Users have no way > to see which name Git uses, and depending on how the system is > configured, it may be a short name ("myhost") or a fully qualified > one ("myhost.example.com"). > > This matters more once the config can depend on the hostname, which > a later commit adds as an includeIf condition. Without a way to see > the value Git uses, users would have to guess what to write in their > config file. > > Add a GIT_HOSTNAME variable to "git var" that prints the hostname > Git sees. If the hostname can't be determined, "git var GIT_HOSTNAME" > exits with a non-zero status, and "git var -l" omits the variable > instead of failing. > > An option to "git config" to show the hostname was also discussed, > but "git var" was chosen, since the hostname is not specific to > the configuration code. > > The test only checks that a non-empty value is printed. The test has > no independent way to know the expected hostname, as the "hostname" > command may not agree with what Git sees on every platform. The > includeIf tests added later check that the value matches what the > configuration code uses. > > Suggested-by: Eric Sunshine > Suggested-by: Jeff King > Signed-off-by: Isabella Caselli > --- > Documentation/git-var.adoc | 3 +++ > builtin/var.c | 13 +++++++++++++ > t/t0007-git-var.sh | 5 +++++ > 3 files changed, 21 insertions(+) Nicely written, and the implementation looks sensible.