From: Junio C Hamano Date: Mon, 02 Nov 2026 04:08:00 GMT Subject: Re: [PATCH] CodingGuidelines: update the required Perl version Message-ID: In-Reply-To: <20261101185846.24208-1-taahol@utu.fi> Tuomas Ahola writes: > 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version > requirement. Update CodingGuidelines accordingly. > > Signed-off-by: Tuomas Ahola > --- > Documentation/CodingGuidelines | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index c06f5d3071..9b17ab34db 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -703,7 +703,7 @@ For Perl programs: > > - Most of the C guidelines above apply. > > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001"). > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000"). Is this in line with what 702d8c1f3b did? Shouldn't we say > + - We try to support Perl 5.26.0 and later ("require v5.26"). "require v5.26" instead? commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd Author: brian m. carlson Date: Wed Oct 23 00:45:59 2024 +0000 Require Perl 5.26.0 ... This change was made with the following one-liner, which intentionally excludes modifying the vendored modules we include to avoid conflicts: git grep -l 'use 5.008001' | grep -v 'LoadCPAN/' | xargs perl -pi -e 's/use 5.008001/require v5.26/' Use require instead of use to avoid changing the behavior as the latter enables features and the former does not. Signed-off-by: brian m. carlson Signed-off-by: Taylor Blau diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm index 636add6968..3d061bc0b7 100644 --- a/contrib/diff-highlight/DiffHighlight.pm +++ b/contrib/diff-highlight/DiffHighlight.pm @@ -1,6 +1,6 @@ package DiffHighlight; -use 5.008001; +require v5.26; use warnings FATAL => 'all'; use strict;