From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Apr 2014 20:52:30 GMT
Subject: Re: [PATCH 3/3] test: fix t5560 on FreeBSD
Message-ID: <xmqqioqfr3ld.fsf@gitster.dls.corp.google.com>
In-Reply-To: <0101ef71fafab90325bb799cb8ad80e@74d39fa044aa309eaea14b9f57fe79c>

"Kyle J. McKay" <mackyle@gmail.com> writes:

> Instead, we can use the [...] construct to defeat the special meaning
> of the '?' character and match it exactly in a way that works for the
> FreeBSD /bin/sh as well as other POSIX /bin/sh implementations.
>
> Changing the example like so:
>
> x='one?two?three'
> echo "${x#*[?]}"
>
> Produces the expected output using the FreeBSD /bin/sh.

I'll queue this in the meantime, while 1&2/3 are sorted out between
you and Matthieu.

I will also take "cp -a" patch with "-R -P -p", not just "-R" for
the reasons stated in the other thread.

Thanks.