From: Junio C Hamano Date: Wed, 16 Jul 2014 17:59:33 GMT Subject: Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig Message-ID: In-Reply-To: <1405467974.2577.21.camel@jekeller-desk1.amr.corp.intel.com> "Keller, Jacob E" writes: > On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote: >> On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: >> >> > +static void error_bad_sort_config(const char *err, va_list params) >> > +{ >> > + vreportf("warning: tag.sort has ", err, params); >> > +} >> >> This feels a little like an abuse of the "prefix" field of vreportf, but >> as you probably saw in my "for fun" patch, doing it right means >> formatting into a buffer and then reformatting that (which we're >> already doing again in vreportf, but less flexibly). I dunno. >> >> At any rate, this should be marked for translation, no? >> >> -Peff > > Oh, yes it probably should. It's definitely a little bit abusive of the > prefix field, but that seemed easier. And i18n would automatically mean this will not work, no? There is no guarantee that the translation of "warning: " will be followed directly by the translation of "tag.sort has" without any words from variable part in all languages. After all, it seems to me that the one in http://thread.gmane.org/gmane.comp.version-control.git/253346 struck the right balance among various abuses; let's use the error reporter from that version, instead of going down this rabbit hole. Thanks.