From: Junio C Hamano Date: Tue, 02 Sep 2014 18:41:11 GMT Subject: Re: [PATCH 4/6] fsck: check tag objects' headers Message-ID: In-Reply-To: <20140829234327.GF24834@peff.net> Jeff King writes: > On Thu, Aug 28, 2014 at 02:25:16PM -0700, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > We inspect commit objects pretty much in detail in git-fsck, but we just >> > glanced over the tag objects. Let's be stricter. >> > >> > This work was sponsored by GitHub Inc. >> >> Is it only this commit, or all of these patches in the series? >> Does GitHub want their name sprinkled over all changes they sponsor? > > GitHub does not really care either way. I think it is well-known that we > sponsor some git development (i.e., pretty much everything I and Michael > work on), and we do not need that fact sprinkled in the commit history. > > But we are also happy for that fact to be transparent if it changes > people's opinions on whether the patch is a good idea (i.e., to know > that Johannes has some motive beyond just "I think this is the right > thing to do"; I hope he _also_ thinks it is the right thing to do or > would not post the series, of course). > > Personally, I think the cover letter is a good place for such things. Yeah, and I saw it explained in the cover. It looked somewhat out of place to see it duplicated only for this patch in the 6 patch series and I was wondering if there was something special about this specific patch, hence my question.