From: Junio C Hamano Date: Tue, 09 Sep 2014 22:41:02 GMT Subject: Re: [PATCH v4 07/32] hold_lock_file_for_append(): release lock on errors Message-ID: In-Reply-To: <1409989846-22401-8-git-send-email-mhagger@alum.mit.edu> Michael Haggerty writes: > If there is an error copying the old contents to the lockfile, roll > back the lockfile before exiting so that the lockfile is not held > until process cleanup. Same comment as 06/32 applies here.