From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 15 Jun 2015 18:53:04 GMT
Subject: Re: [PATCH v2 08/12] initial_ref_transaction_commit(): function for initial ref creation
Message-ID: <xmqqioao952n.fsf@gitster.dls.corp.google.com>
In-Reply-To: <19f421f504ae22538fd2a902840209c0799e67cb.1434206062.git.mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> +	struct ref_transaction *t;
> +	struct strbuf err = STRBUF_INIT;
> +
> +	t = ref_transaction_begin(&err);
> +	if (!t)
> +		die(err.buf);

Yikes, and sorry for sending three messages without consolidating
against the same patch, but

	die("%s", err.buf);

because

extern NORETURN void die(const char *err, ...) __attribute__((format (printf, 1, 2)));

in its declaration causes -Werror=format-security to barf.

Likewise for a few other instances of the same construct all in 
the same file.