From: Junio C Hamano Date: Sat, 01 Aug 2015 01:02:52 GMT Subject: Re: [RFC/PATCH 2/2] Testing the new code Message-ID: In-Reply-To: <1438384147-3275-3-git-send-email-sbeller@google.com> Stefan Beller writes: > -module_list() > +module_list_shell() > { > eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")" > ( > @@ -187,6 +187,29 @@ module_list() > ' > } > > +module_list() > +{ > + # call both the old and new code > + module_list_shell $@ >/u/git_submodule_module_list_shell 2>/u/git_submodule_module_list_shell2 > + git submodule--helper --module_list $@ >/u/git_submodule_module_list 2>/u/git_submodule_module_list2 You seem to be discarding the double-quote around $@ in both of these two places. Intended?