From: Junio C Hamano Date: Tue, 16 Feb 2016 21:36:47 GMT Subject: Re: [PATCH v3 0/4] git remote improvements Message-ID: In-Reply-To: <1455616072-20838-1-git-send-email-t.gummerer@gmail.com> Thomas Gummerer writes: > Previous rounds are at $gmane/286214 and $gmane/286278. Thanks to > Peff and Eric for the reviews on the previous round. > > This version changes two checks in [1/4], and uses test_config in the > tests instead of calling git config directly. Thanks; I agree that 1/4 is a noisy patch but the culprit of the noisyness is that the old code, when doing tons of comparisons with fixed strings that begin with a dot, did not think it was crazy not to increment the "subkey" before doing so, and the resulting code is much easier to follow. Thanks.