From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 May 2016 22:54:25 GMT
Subject: Re: [PATCH v5 2/9] connect: only match the host with core.gitProxy
Message-ID: <xmqqinydzk9q.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160516223639.GA16182@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> The gitProxy script gets the port passed. Why would you need different
> scripts for different ports if the port is passed as an argument? Also,
> if it's deliberate, it's widely undocumented.

Fair enough.

A user who has been working around thsi "oversight", would have
relied on her proxy configured with 'script for myhost.xz:9111' to
be called for git://myhost.xz:9111/path, right?  We'd need to
somehow let her know that her configuration will be broken, but as
long as we can find a way to do so to ease the transition, I think
the updated "if you want to use a different behaviour depending on
port, use the port parameter" is a lot more sensible behaviour than
what we had traditionally.