From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 Jun 2016 22:03:15 GMT
Subject: Re: [PATCH] pathspec: rename free_pathspec() to clear_pathspec()
Message-ID: <xmqqinxrs0yk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160602212938.GA13071@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think diff_filespec_clear() would not be quite right. It is freeing
> only the allocated _data_, but leaving the other portions intact.

You are (as usual) more right than I am ;-)

Yes, the free_data() is designed to retain enough information about
the filespec so that the data can be re-read by the next person who
needs to access it after free_data() is called; i.e. it was a
measure to reduce the memory pressure by trading it off with I/O
cost.  It is wrong to name it "clear", which is to "clear the slate,
make it into pristine state" whose side effect is to release held
resources.