From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Sep 2016 19:51:01 GMT
Subject: Re: [PATCH v14 00/41] libify apply and use lib in am, part 2
Message-ID: <xmqqinu7lc9m.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160904201833.21676-1-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

> In patch 29/41 I added some comments in apply.h above the definition
> of APPLY_OPT_INACCURATE_EOF and APPLY_OPT_RECOUNT, as suggested by
> Stefan. This is the only change compared to v13.

OK.


>   - Patches 33/41 to 37/41 were in v10, v12 and v13.
>
> They implement a way to make the libified apply code silent by
> changing the bool `apply_verbosely` into a tristate enum called
> `apply_verbosity`, that can be one of `verbosity_verbose`,
> `verbosity_normal` or `verbosity_silent`.

This is a reasonable approach.

> The only changes since v13 are in 37/41. The name of the first
> argument to mute_routine() is changed from "bla" to "msg" as suggested
> by Ramsey, and the commit message is improved as suggested by Stefan.

;-)

>   - Patch 40/41 was in v12 and v13, and hasn't changed.
>
> It adds a "const char *index_file" into "struct apply_state", to make
> it possible to use a special index file instead of the default one.

Looks sensible.