From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Nov 2016 23:46:39 GMT
Subject: Re: [PATCH] difftool.c: mark a file-local symbol with static
Message-ID: <xmqqinr4bkf4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161130231848.v5ge6otytim2t6d2@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I forgot, we ended up reversing course later and silencing them:
>
>   http://public-inbox.org/git/20140505052117.GC6569@sigill.intra.peff.net/
>
> By the rationale of that conversation, we should be doing:
>
>   warning("%s", "");
>
> here.

I forgot too.  Thanks for digging up that thread.