From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 26 Jul 2021 20:02:54 GMT
Subject: Re: [PATCH v2 05/12] diffcore-rename: move old_dir/new_dir definition to plug leak
Message-ID: <xmqqim0wj11t.fsf@gitster.g>
In-Reply-To: <20210725130830.5145-6-andrzej@ahunt.org>

andrzej@ahunt.org writes:

> From: Andrzej Hunt <ajrhunt@google.com>
>
> old_dir/new_dir are free()'d at the end of update_dir_rename_counts,
> however if we return early we'll never free those strings. Therefore
> we should move all new allocations after the possible early return,
> avoiding a leak.
>
> This seems like a fairly recent leak, that started happening since the
> early-return was added in:
>   1ad69eb0dc (diffcore-rename: compute dir_rename_counts in stages, 2021-02-27)

Yup.  It is not surprising to have issues in younger parts of the
code.  Thanks.