From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 12 Sep 2021 19:01:54 GMT
Subject: Re: [PATCH v3 0/9] post-v2.33 "drop support for ancient curl" follow-up
Message-ID: <xmqqilz5lisd.fsf@gitster.g>
In-Reply-To: <YTzBUFY4p6obEqF+@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Probably not worth a re-roll, but maybe worth fixing up while applying:
>
>>  2:  4b653cee2d3 !  3:  dce6520a5c9 INSTALL: mention that we need libcurl 7.19.4 or newer to build
>>     @@ Commit message
>>      
>>       ## INSTALL ##
>>      @@ INSTALL: Issues of note:
>>     - 	- "libcurl" library is used by git-http-fetch, git-fetch, and, if
>>     - 	  the curl version >= 7.34.0, for git-imap-send.
>>     + 	  not need that functionality, use NO_CURL to build without
>>     + 	  it.
>>       
>>     -+	  Git version "7.19.4" of "libcurl" or later to build. This
>>     -+	  version requirement may be bumped in the future.
>>     ++	  Git requires version "7.19.4" or later of "libcurl", to
>>     ++	  build (without NO_CURL). This version requirement may be
>>     ++	  bumped in the future.
>
> The comma after libcurl (before "to build") is extraneous (and IMHO
> makes the sentence harder to read).

Yes.  Also it would make it easier to follow if the parentheses
around "without NO_CURL" are removed, I would think.