From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Oct 2021 23:32:07 GMT
Subject: Re: [PATCH v2 3/3] config.c: free(expanded) before die(), work around GCC oddity
Message-ID: <xmqqilxqgdjc.fsf@gitster.g>
In-Reply-To: <patch-v2-3.3-d812358e331-20211021T195133Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

>  cleanup:
>  	strbuf_release(&buf);
>  	free(expanded);
> -	return ret;
> +	if (!die_depth)
> +		return ret;
> +	die(_(include_depth_advice), MAX_INCLUDE_DEPTH, path,
> +	    !cf ? "<unknown>" : cf->name ? cf->name : "the command line");
>  }

Yuck.  With or without compiler bugs, this code is too ugly to live,
isn't it?