From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 04 Mar 2022 22:58:19 GMT
Subject: Re: [PATCH 07/11] bundle: safely handle --objects option
Message-ID: <xmqqilstxr3o.fsf@gitster.g>
In-Reply-To: <83bfbce4-3c79-031a-5961-429145910409@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

> On 2/23/22 12:55 PM, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <derrickstolee@github.com>
>> Since 'git bundle' uses setup_revisions() to specify the object
>> walk,
>> some options do not make sense to include during the pack-objects child
>> process. Further, these options are used for a call to
>> traverse_commit_list() which would then require a callback which is
>> currently NULL.
>> By populating the callback we prevent a segfault in the case of
>> adding
>> the --objects flag. This is really a redundant statement because the
>
> Nit: I stumbled over "...because the bundles are constructing..."
> Is there a better wording here??

"... because the command is constructing ..." should be sufficient,
I hope?