From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 16 Jan 2024 23:40:01 GMT
Subject: Re: [RFC PATCH 2/4] test-tool run-command testsuite: support unit tests
Message-ID: <xmqqil3sx2y6.fsf@gitster.g>
In-Reply-To: <xmqqv87sx3y2.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Josh Steadmon <steadmon@google.com> writes:
>
>> Teach the testsuite runner in `test-tool run-command testsuite` how to
>> run unit tests, by adding two new flags:
>>
>> First, "--(no-)run-in-shell" allows the test-tool to exec the unit-test
>> binaries directly, rather than trying to interpret them as shell
>> scripts.
>
> Makes perfect sense.

This may be a stupid question, but do we even need the current "push
'sh' to the strvec"?  If our executable shell scripts run just fine
without, then this may not have to be conditional.