From: Junio C Hamano Date: Mon, 29 Apr 2024 17:04:15 GMT Subject: Re: [PATCH] builtin/tag.c: add --trailer arg Message-ID: In-Reply-To: John Passaro writes: >> More importantly, I doubt that many trailers we commonly see in the >> comit objects, like "Acked-by", "Reviewed-by", or even "CC", are >> applicable in the context of tags. So I am ambivalent. > > A couple of words on the motivation here. First, by way of --list > --format="%(trailer)", > git-tag arguably has read-side support for trailers already; adding write > support seems pretty reasonable. Second, even though not all the trailers > broadly used for commits are an obvious fit for tags, some still are - > "Signed-off-by" for one would seem plausibly useful. In my team's usage (which > inspired this change), tag trailers have emerged as a convenient way to pass > machine-readable metadata to CICD. That is a good thing to describe in the proposed log message. If a reviewer feels puzzled by a commit and did not get the motivation from the proposed log message, there is a good chance that the motivation is not well described to help future developers who find this commit in "git log" output. Thanks.