From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 11 Jul 2024 15:12:06 GMT
Subject: Re: [PATCH 0/6] unit-tests: add and use TEST_RUN to simplify tests
Message-ID: <xmqqikxcnet5.fsf@gitster.g>
In-Reply-To: <38c962cd-2691-4664-b262-6eb78b8a61b5@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 10/07/2024 23:13, Junio C Hamano wrote:
>> René Scharfe <l.s.r@web.de> writes:
>>
>> So, looking back the discussion list on
>>    https://lore.kernel.org/git/85b6b8a9-ee5f-42ab-bcbc-49976b30ef33@web.de/
>> any loose ends still need to be addressed?  I didn't spot any
>> myself, so I am willing to merge it to 'next' soonish, but please
>> stop me if there were something I missed.
>
> I thought René was planning a re-roll to avoid using xstrfmt() in
> Patch 2 c.f <97390954-49bc-48c4-bab1-95be10717aca@web.de>. Also I'm
> not sure we've reached a conclusion on whether to include the "if" in
> the macro or require the user to write "if(TEST_RUN(...))". My
> impression is that there is a consensus building around having the
> macro include the "if" but we haven't decided what to call it
> c.f. <62d221cc-532a-4a6d-8e96-b5a246ddeb1b@web.de>
>
> Best Wishes

Thanks.  Very much appreciated.