From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 21 Dec 2024 17:13:11 GMT
Subject: Re: [PATCH 2/4] reftable/merged: fix zero-sized allocation when there are no readers
Message-ID: <xmqqikrdc63c.fsf@gitster.g>
In-Reply-To: <b4ba502a-b689-4736-9712-443a137b5d2c@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> Hi
>
> On Sat, Dec 21, 2024, at 12:50, Patrick Steinhardt wrote:
>> It was reported [1c
>
> A Neo user, I see.
>
> s/c/]/
>
>> [snip]
>> the result. Now that we do we notice and thus return an out-of-memory
>> error to the caller.
>
> s/Now that we do we/Now we do notice/
>
> Repeat of “we”.  And “that” can’t be be used since it has nothing to
> connect to.

I read "Now that we do, we notice and ..." a perfectly sensible
construct, though.

Thanks.