From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 Jul 2025 14:30:01 GMT
Subject: Re: [PATCH 9/9] sub-process: do not use strbuf_split*()
Message-ID: <xmqqikj8touu.fsf@gitster.g>
In-Reply-To: <CAP8UFD2qAOhRN=b9PB_eXQS1PntZKX95ZK=V4G=10n3iU2xtbw@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> On Thu, Jul 31, 2025 at 9:44 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> The code to read status from subprocess reads one packet line and
>> tries to find "status=<foo>".  It is way overkill to split the line
>> into an array of two strbufs to extract <foo>.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  sub-process.c | 16 +++++++---------
>>  1 file changed, 7 insertions(+), 9 deletions(-)
>>
>> diff --git a/sub-process.c b/sub-process.c
>> index 1daf5a9752..de3235c15a 100644
>> --- a/sub-process.c
>> +++ b/sub-process.c
>> @@ -5,6 +5,7 @@
>>  #include "sub-process.h"
>>  #include "sigchain.h"
>>  #include "pkt-line.h"
>> +#include "string-list.h"
>
> Is this needed? It looks like skip_prefix() (not any string_list
> function) is used instead of strbuf_split_str().

Yes, as you suspected, I initially rewrote strbuf_split*() with
string_list_split*(), but then realized there is no need to split
the string into tokens in the first place.

Will remove the unused include.
Thanks for carefully reading.