From: Junio C Hamano Date: Sat, 08 Aug 2026 16:23:34 GMT Subject: Re: [PATCH v6 0/6] packfile URIs: support concurrent downloads Message-ID: In-Reply-To: <20260801140255.GC2041176@coredump.intra.peff.net> Jeff King writes: > On Wed, Jul 29, 2026 at 02:41:51PM -0700, Junio C Hamano wrote: > >> Ted Nyman writes: >> >> > Changes since v5: >> > >> > * Split the existing double-close fix, HTTP 416 handling, generic >> > concurrent-download fix, and Windows sharing fix into separate >> > patches. >> > * Replace the FIFO-based concurrent HTTP 416 test with a standalone >> > completed-partial test. Besides simplifying the test, this covers the >> > non-concurrent interrupted-download case directly. >> > * Keep the final production code unchanged. >> > >> > Each patch passes t5550-http-fetch-dumb.sh. The final series also passes >> > t5702-protocol-v2.sh, and the overlapping-download test passes 240 runs >> > with 12 parallel stress jobs. >> > >> > The v5 discussion is at: >> > >> > https://lore.kernel.org/git/cover.1785047139.git.tnyman@openai.com/ >> >> Is everybody happy with this new iteration? >> >> The design of the re-download feature itself, as far as I >> understand, was favourably accepted from the earliest iteration, and >> now the CI breakages were corrected with the latest iteration of the >> tests, so we should be in pretty good shape, I presume. > > Yeah, sorry, I hadn't had time to look carefully. I just did so, and it > all looks good to me. v6 splits the patches in a way that (at least to > my mind) make the trickiest parts of the logic easier to follow. Thanks.