From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Nov 2026 20:56:51 GMT
Subject: Re: [PATCH v2 3/4] http: add http.retryStatusCodes config option
Message-ID: <xmqqik2d63cc.fsf@gitster.g>
In-Reply-To: <6510dddc39ca61fe1ae2f81cb8e7febd5f82d5ca.1793732247.git.gitgitgadget@gmail.com>

"Ravi Mistry via GitGitGadget" <gitgitgadget@gmail.com> writes:

>  http.retryAfter::
>  	Initial wait time in seconds before retrying when a server returns
> -	HTTP 429 (Too Many Requests) without a Retry-After header.
> +	a retryable HTTP status code without a Retry-After header. The
> +	set of retryable status codes is configured by
> +	`http.retryStatusCodes`, which includes only HTTP 429 (Too Many
> +	Requests) by default.

I as a lazy person would probably have written

	... when a server returns a retryable HTTP status code (see
	`http.retryStatusCodes`) without a Retry-After header.

and omitted everything else, but this is better by being more self
contained ;-).

Looking good.

By the way, after the dust settles, we should fix the formatting of
these variable name entries wholesale.  Looking at a few files in
the same directory, like log.adoc and grep.adoc:

    $ git grep -h '^[^ ]*::$' Documentation/config/{log,grep}.adoc
    `grep.lineNumber`::
    `grep.column`::
    `grep.patternType`::
    `grep.extendedRegexp`::
    `grep.threads`::
    `grep.fullName`::
    `grep.fallbackToNoIndex`::
    `log.abbrevCommit`::
    `log.date`::
    `log.decorate`::
    `log.initialDecorationSet`::
    `log.excludeDecoration`::
    `log.diffMerges`::
    `log.follow`::
    `log.graphColors`::
    `log.graphIndent`::
    `log.showRoot`::
    `log.showSignature`::
    `log.mailmap`::

these names are supposed to be marked up in certain ways, but none
in this file is.

Anyway, the whole series was a pleasant read.  Thanks.