From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Aug 2013 18:13:19 GMT
Subject: Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names
Message-ID: <xmqqhae7yrls.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqppsvyrzj.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> Acked-by: Jakub Narębski <jnareb@gmail.com>
>> Tested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> Tested-by: Simon Ruderich <simon@ruderich.org>
>> ---
>> +++ b/gitweb/gitweb.perl
>> @@ -6631,6 +6631,7 @@ sub git_blame_common {
>> ...
>> +	binmode $fh, ':utf8';

>
> [Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
> explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
> [Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.

I think in this function the filehandle is called $fd, not $fh.  Has
any of you really tested this???