From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Sep 2013 16:06:59 GMT
Subject: Re: [PATCH-v3] Allow git-filter-branch to process large repositories with lots of branches.
Message-ID: <xmqqhadruyu4.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CE550501.19691%lee.carver@corp.service-now.com>

Lee Carver <Lee.Carver@servicenow.com> writes:

> It is using the same ${tempdir} working directory that git rev-list uses
> below for the ../revs file

Ah, I missed that; then that should be safe.  The patch looks sane.

Can we have your sign-off, too, please?

>
> It's normally .git-rewrite/t, following the normal working directory setup
> near line 205.
>
>>
>>>  
>>>  case "$filter_subdir" in
>>>  "")
>>> @@ -268,7 +268,7 @@ case "$filter_subdir" in
>>>  esac
>>>  
>>>  git rev-list --reverse --topo-order --default HEAD \
>>> -	--parents --simplify-merges $rev_args "$@" > ../revs ||
>>> +	--parents --simplify-merges --stdin "$@" < ../parse > ../revs ||
>>>  	die "Could not get the commits"
>>>  commits=$(wc -l <../revs | tr -d " ")