From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Sep 2013 16:17:35 GMT
Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined
Message-ID: <xmqqhadj1kyo.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAHGBnuOfYoosgWQdfF+L3=YCqO-MYEx-TpNzBAD-Zt0kqeR_Hw@mail.gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

> I think this is less favorable compared to my last proposed solution.

That is only needed if you insist to use C preprocessor that does
not understand include_next.  That choice is a platform specific
decision (even if you want to use such a compiler on a platform it
may not have been ported to yours, etc.).

Keeping the ugliness to deal with the platform issue (i.e. broken
string.h) in one place (e.g. compat/mingw) is far more preferrable
than having a similar ugliness in git-compat-util.h for people on
all other platforms to see, no?