From: Junio C Hamano <junio@pobox.com>
Date: Tue, 01 Apr 2014 22:51:54 GMT
Subject: Re: [PATCH v9 08/11] trailer: add tests for "git interpret-trailers"
Message-ID: <xmqqha6cy86t.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140401192023.353.56221.chriscool@tuxfamily.org>

Junio C Hamano <gitster@pobox.com> writes:

> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> +test_expect_success '--trim-empty without config' '
>> +	cat >expected <<-\EOF &&
>> +		ack: Peff
>> +		Acked-by: Johan
>> +	EOF
>> +	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>> +	test_cmp expected actual
>> +'
>
> Let's avoid these overlong and unreadable lines by doing something
> like this (just one hunk shown for illustration):
>
>  		ack: Peff
>  		Acked-by: Johan
>  	EOF
> -	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
> +	git interpret-trailers --trim-empty "ack = Peff" \
> +		"Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>  	test_cmp expected actual
>  '
>  

I'll squash in the line-chopping fix to this, and also fill a
missing whitespace in 3/11 before pushing it out to 'pu'.  Hopefully
the result can be later merged to 'next' without further rerolls.

Thanks.