From: Junio C Hamano Date: Mon, 14 Jul 2014 21:18:03 GMT Subject: Re: No fchmod() under msygit - Was: Re: [PATCH 00/14] Add submodule test harness Message-ID: In-Reply-To: <53C42FE0.10904@gmail.com> Karsten Blees writes: > 1.) Permissions of files in .git are controlled by the core.sharedRepository > setting, and your patch seems to break that (i.e. if someone accidentally > has made .git/config world readable, git-config no longer fixes that, even > if core.sharedRepository=0600). For any repository, when you further run "git config" to update it, .git/config always exists with the permission bits initialized when "git init" was run there. And Eric's change is to propagate that same bits to a new file, so there wouldn't be any difference, no? And $HOME/.gitconfig should not be governed by "sharedRepository", and that was the primary focus of Eric's change, I would think.