From: Junio C Hamano Date: Fri, 08 Apr 2016 20:30:18 GMT Subject: Re: [PATCH 3/7] l10n: git-parse-remote.sh: mark strings for translation Message-ID: In-Reply-To: <1460145765-7454-3-git-send-email-vascomalmeida@sapo.pt> Vasco Almeida writes: > + gettextln "You are not currently on a branch." > + if test $op_type = "rebase" if test "$op_type" = rebase that is, $op_type could be an empty string that 'test' may not even see hence it should be double-quoted to ensure 'test' sees an empty string in that case, while "rebase" cannot be an empty string by definition so there is no need to quote it. Thanks.