From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 24 Sep 2016 17:52:39 GMT
Subject: Re: [PATCH v3 2/2] gitweb: use highlight's shebang detection
Message-ID: <xmqqh995yyl4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <946807ff-1570-2d81-1026-06529164f8ef@gmail.com>

Jakub Narębski <jnareb@gmail.com> writes:

>> Also, "curling" is not the word I would like to see. I would say:
>> 
>>   Simple benchmark comparing performance of 'blob' view of files without
>>   syntax highlighting in gitweb before and after this change indicates
>>   ±1% difference in request time for all file types.  Benchmark was
>>   performed on local instance on Debian, using Apache/2.4.23 web server
>>   and CGI/PSGI/FCGI/mod_perl.
>> 
>>       ^^^^^^^^^^^^^^^^^^^^^^--- select one

or state that all of them produced similar results ;-)

>> Or something like that; I'm not sure how detailed this should be.
>> But it is nice to have such benchmark in the commit message.
>
> Sidenote: this way of benchmarking of gitweb falls between two ways of
> doing a benchmark.

All good comments.  Thanks.