From: Junio C Hamano Date: Mon, 10 Oct 2016 23:08:14 GMT Subject: Re: [PATCH 1/3] Resurrect "diff-lib.c: adjust position of i-t-a entries in diff" Message-ID: In-Reply-To: Duy Nguyen writes: > Off topic. This reminds me of an old patch about apply and ita [1] but > that one is not the same here ... Yeah, and re-reading that one, I think that sort-of makes sense. I am hesitant to take it out of context, though. I wonder how it would interact with that broken mode of "git apply" where it can take patches to the same path number of times... > [1] https://public-inbox.org/git/1451181092-26054-4-git-send-email-pclouds@gmail.com/ >> ita entry in the index for symmetry, wouldn't it? That by itself >> can be seen as an improvement (we no longer would have to say that >> "git apply patchfile && git commit -a" that is run in a clean state >> will forget new files the patchfile creates), but it also means ... Another downside is that "git reset --hard" after "git apply" will suddenly start removing them. Perhaps that can be seen a feature? I dunno.