From: Junio C Hamano Date: Fri, 16 Dec 2016 19:05:51 GMT Subject: Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it Message-ID: In-Reply-To: <5977e71d-da58-7cb0-bc69-343bb3a1341d@kdbg.org> Johannes Sixt writes: > Am 16.12.2016 um 19:08 schrieb Junio C Hamano: >> Sorry for not having waited for you to chime in before agreeing to >> fast-track this one, and now this is in 'master'. > > No reason to be sorry, things happen... Dscho's request for > fast-tracking was very reasonable, and the patch looked "obviously > correct". Oh, I do agree it was reasonable and looked obviously correct. And I suspect that it did not make anything worse, either, so there is not much harm done, other than that I now have to remember not to merge it down without further fixes to 'maint' and declare the NUL thing fixed ;-) > Unfortunately, I'm away from my Windows box over the weekend. It will > have to wait until Monday before I can test this idea. Thanks.