From: Junio C Hamano Date: Thu, 02 Aug 2018 18:44:50 GMT Subject: Re: [RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up Message-ID: In-Reply-To: <20180802164042.28026-1-szeder.dev@gmail.com> SZEDER Gábor writes: >> Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with >> invalid lines in .gitmodules but then only the second commit is removed. >> >> This may affect future subsequent tests if they assume that the >> .gitmodules file has no errors. >> >> Since those commits are not needed anymore remove both of them. >> >> The modified line is in the last test of the file, so this does not >> change the current behavior, it only affects future tests. >> >> Signed-off-by: Antonio Ospite >> --- >> >> Note that test_when_finished is not used here, both to keep the current style >> and also because it does not work in sub-shells. > > That's true, but I think that this: > > test_when_finished git -C super reset --hard HEAD~2 > > at the very beginning of the test should work. Assuming that the operations to create these two extra commits always succeed, yes, that would be a more robust and preferrable option. I don't know if that assumption hold true offhand, though. Don't we have a more stable point to anchor that going-back-to commit to?