From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Sep 2018 20:29:07 GMT
Subject: Re: [PATCH] commit-reach: cleanups in can_all_from_reach...
Message-ID: <xmqqh8idpbho.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <08b67726-8af6-34f9-6c4f-6a1be7d81b90@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

> Another commit walk that could be improved by generation numbers? It's
> like my bat-signal!

Ah, nevermind.  The "traversal" done by these helper functions is
the most stupid kind (not the algorthim, but the need).  It's not
like there is an opportunity to optimize by not traversing the
remainder if we choose the order of traversal intelligently, so any
algorithm that does not visit the same node twice and does not do
the most naive recursion would work, and what we currently have
there is just fine.