From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 15 Oct 2018 02:34:53 GMT
Subject: Re: [PATCH] object_id.cocci: match only expressions of type 'struct object_id'
Message-ID: <xmqqh8ho6ipe.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181012131116.23733-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Most of our semantic patches in 'contrib/coccinelle/object_id.cocci'
> turn calls of SHA1-specific functions into calls of their
> corresponding object_id counterparts, e.g. sha1_to_hex() to
> oid_to_hex().  These semantic patches look something like this:
>
>   @@
>   expression E1;
>   @@
>   - sha1_to_hex(E1.hash)
>   + oid_to_hex(&E1)
>
> and match the access to the 'hash' field in any data type, not only in
> 'struct object_id', and, consquently, can produce wrong
> transformations.

Thanks, will queue.