From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Feb 2020 17:49:45 GMT
Subject: Re: [PATCH 4/4] parse-options: simplify parse_options_dup()
Message-ID: <xmqqh7zy1gee.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <162fb36a-6dd1-c178-9032-d3f4213930a6@web.de>

René Scharfe <l.s.r@web.de> writes:

> Simplify parse_options_dup() by making it a trivial wrapper of
> parse_options_concat() by making use of the facts that the latter
> duplicates its input as well and that appending an empty set is a no-op.
> ...
> +	struct option no_options[] = { OPT_END() };
> +
> +	return parse_options_concat(o, no_options);

Can't say if this is tricky or cute, but I like it ;-)

Will queue all four.  Thanks.