From: Junio C Hamano Date: Wed, 04 Mar 2020 16:25:30 GMT Subject: Re: [PATCH v2 2/2] stash: remove the stash.useBuiltin setting Message-ID: In-Reply-To: <20200304114909.GD1571684@cat> Thomas Gummerer writes: > On 03/03, Junio C Hamano wrote: >> Thomas Gummerer writes: >> >> > + Unused configuration Variable. Used in Git versions 2.22 to >> >> s/Variable/variable/; > > Whoops. Do you want me to re-send an updated version, or could you > fix this up locally? After reading your response to the end, it appears that there is no other changes needed, so let me do the honors ;-) >> I am a bit torn between "just document it here as a stale variable >> that can safely be removed from your configuration, and do not warn" >> and what you did here. Even if we warn for a few releases, this >> entry cannot be removed from the documentation for a lot longer >> time, if ever, anyway. It's not like having an extra entry that is >> unused in the configuration file would hurt users, anyway, and it is >> not obvious that the warning helps more than it disrupts them by >> bugging users to remove it from their configuration file. > > Hmm I'm thinking of the warning mostly as preventing the "I have > legacy stash enabled, why do I see a new bug all of a sudden?" > question, as opposed to it helping removing this from the docs. OK. Thanks.