From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Apr 2020 22:21:35 GMT
Subject: Re: [PATCH v2 2/4] commit: write commit-graph with Bloom filters
Message-ID: <xmqqh7xnauxc.fsf@gitster.c.googlers.com>
In-Reply-To: <20200413161245.GE59601@syl.local>

Taylor Blau <me@ttaylorr.com> writes:

> Hmm. I'm not crazy about a library function looking at 'GIT_TEST_*'
> environment variables and potentially ignoring its arguments, but given
> the discussion we had in v1, I don't feel strongly enough to recommend
> that you change this.
>
> For what it's worth, I think that 'write_commit_graph' could behave more
> purely if callers checked 'GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS' and set
> 'flags' appropriately from the outside,...

Yeah, I agree that it would be a lot cleaner if that is easy to
arrange.  I have a suspicion that Derrick already tried and the
resulting code looked messier and was discarded?