From: Junio C Hamano Date: Wed, 15 Apr 2020 20:36:19 GMT Subject: Re: [PATCH v12 4/7] send-pack: extension for client-side status report Message-ID: In-Reply-To: <20200414123257.27449-5-worldhello.net@gmail.com> Jiang Xin writes: > + if (msg) > + hint->remote_status = xstrdup(msg); > + else if (extended_status) > + hint->remote_status = xstrdup(extended_status); contrib/coccinelle/xstrdup_or_null.cocci suggests to rewrite the above like so: if (msg) hint->remote_status = xstrdup(msg); else hint->remote_status = xstrdup_or_null(extended_status); I'll queue a fix-up patch to keep 'pu' passing the test suite for now.