From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 27 Sep 2020 20:23:25 GMT
Subject: Re: [PATCH v2 5/8] shortlog: de-duplicate trailer values
Message-ID: <xmqqh7rjnf42.fsf@gitster.c.googlers.com>
In-Reply-To: <20200927084007.GE2465761@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The current documentation is vague about what happens with
> --group=trailer:signed-off-by when we see a commit with:
>
>   Signed-off-by: One
>   Signed-off-by: Two
>   Signed-off-by: One
>
> We clearly should credit both "One" and "Two", but should "One" get
> credited twice? The current code does so, but mostly because that was
> the easiest thing to do.

I thought that "the current documentation" as of step 4/8 were quite
clear about double counting ;-).

> It's probably more useful to count each commit
> at most once. This will become especially important when we allow
> values from multiple sources in a future patch.

Yup.  Makes readers want to read further ;-)