From: Junio C Hamano Date: Tue, 15 Dec 2020 22:09:03 GMT Subject: Re: [PATCH v2 00/11] merge-ort: add basic rename detection Message-ID: In-Reply-To: <6448806f-791b-610a-06de-7be5650334e6@gmail.com> Derrick Stolee writes: > On 12/14/2020 11:21 AM, Elijah Newren via GitGitGadget wrote: >> This series builds on en/merge-ort-2 and adds basic rename detection to >> merge-ort. > > I have now finished a full pass through this series. I find it to be > well organized with a satisfying conclusion. My comments are mostly > about nits. I tried to recommend some better organization, but failed > to find a clear way to do so, which shows that the organization here > is sound. > > My only complaint is that some of the patches break compilation, so > that should definitely be fixed to assist with bisects in the future > (likely for bisects unrelated to this feature). Thanks.