From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 May 2021 00:55:52 GMT
Subject: Re: [PATCH 22/22] p5326: perf tests for MIDX bitmaps
Message-ID: <xmqqh7ji578n.fsf@gitster.g>
In-Reply-To: <20210504180058.2988580-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> There is slight overhead in "simulated clone", "simulated partial
>> clone", and "clone (partial bitmap)". Unsurprisingly, that overhead is
>> due to using the MIDX's reverse index to map between bit positions and
>> MIDX positions.
>
> Thanks - it's great to see that accessing a MIDX bitmap doesn't add much
> overhead (as compared to accessing a single-pack bitmap of the same
> size).
>
> All the remaining patches up to and including this one look good.
> Overall, I did have some comments here and there, but I am happy with
> the overall design.

Thanks for a review.