From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Jun 2022 17:44:17 GMT
Subject: Re: [RFC PATCH 03/15] reftable: don't memset() a NULL from failed malloc()
Message-ID: <xmqqh74x8z66.fsf@gitster.g>
In-Reply-To: <220606.864k0xwuyl.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Yes, but I think in this case most of these are either 100% legitimate
> issues, or things where we'd like to e.g. add a BUG() assertion anyway,
> e.g. in the diff parsing case.

Where does that "BUG() assertion anyway" comes from?  What are we
protecting against?

I do not think such a BUG() added only for placating -fanalyzer
falls into "legitimate" category at all.