From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 May 2024 17:22:54 GMT
Subject: Re: Possible git-diff bug when using exit-code with diff filters
Message-ID: <xmqqh6fazwgh.fsf@gitster.g>
In-Reply-To: <caa6cca4-182f-4788-b08e-35806879fdca@web.de>

René Scharfe <l.s.r@web.de> writes:

> Am 21.04.24 um 20:17 schrieb Junio C Hamano:
>> A much simpler fix may be to declare that these two features are
>> imcompatible and fail the execution upfront, instead of just
>> silently ignoring one of the two options.
>
> It would not be *that* simple -- if we want to error out upfront we'd
> have to evaluate the attributes of all files (or all changed files)
> first to see whether they require an external diff.

You're absolutely right.

> Reporting the incompatibility in the middle of a diff would be easier,
> but I don't see why we shouldn't support that combination.  It takes
> some effort, sure, but not prohibitively much.

OK.  Thanks.