From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 28 Sep 2025 15:49:01 GMT
Subject: Re: [PATCH v3 1/2] Revert "gitk: Only restore window size from ~/.gitk, not position"
Message-ID: <xmqqh5wm7f2q.fsf@gitster.g>
In-Reply-To: <20250928135435.59623-2-rappazzo@gmail.com>

Michael Rappazzo <rappazzo@gmail.com> writes:

> From: Johannes Sixt <johannes.sixt@telecom.at>
>
> This reverts commit b9bee11526ec23541ddbbd75716bfd1acc241463.

If you wrote it like

    Revert b9bee115 (gitk: Only restore window size from ~/.gitk,
    not position, 2008-03-10).

it would make it obvious that this is not a revert of a recent
screwup, but historical wart carried from long time ago.

> The commit catered to an unsupportable port of the Windows Tcl/Tk
> stuck at 8.4.1 that was used by Cygwin. 8.4.1 has some bad bugs in its
> layout engine, and forced changes in Gitk to be compatible. All this
> became irrelevant around 2011 after Cygwin gained an X11 server and
> switched to a supportable port of the Unix/X11 Tcl/Tk (it is now on the
> current 8.6 code base).
>
> Helped-by: Mark Levedahl <mlevedahl@gmail.com>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---

Very nice to see such a clean-up.