From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Mar 2026 22:29:38 GMT
Subject: Re: [PATCH v3 1/3] commit: remove unused forward declaration
Message-ID: <xmqqh5qns4h9.fsf@gitster.g>
In-Reply-To: <20260310201116.1130160-2-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

> In 6206089cbd (commit: write commits for both hashes, 2023-10-01),
> `sign_with_header()` was removed, but its forward declaration in
> "commit.h" was left. Remove the unused declaration.
>
> Signed-off-by: Justin Tobler <jltobler@gmail.com>
> ---
>  commit.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/commit.h b/commit.h
> index 1635de418b..f0c38cb444 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -390,8 +390,6 @@ LAST_ARG_MUST_BE_NULL
>  int run_commit_hook(int editor_is_used, const char *index_file,
>  		    int *invoked_hook, const char *name, ...);
>  
> -/* Sign a commit or tag buffer, storing the result in a header. */
> -int sign_with_header(struct strbuf *buf, const char *keyid);
>  /* Parse the signature out of a header. */
>  int parse_buffer_signed_by_header(const char *buffer,
>  				  unsigned long size,

Nice and obvious clean-up.