From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 Jun 2014 20:36:11 GMT
Subject: Re: [PATCH v3 04/14] refs.c: add a new update_type field to ref_update
Message-ID: <xmqqfvj2hs5g.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1403111346-18466-5-git-send-email-sahlberg@google.com>

Ronnie Sahlberg <sahlberg@google.com> writes:

> Add a field that describes what type of update this refers to. For now
> the only type is UPDATE_SHA1 but we will soon add more types.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> ---
>  refs.c | 25 +++++++++++++++++++++----
>  1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/refs.c b/refs.c
> index 4e3d4c3..4129de6 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -3374,6 +3374,10 @@ int for_each_reflog(each_ref_fn fn, void *cb_data)
>  	return retval;
>  }
>  
> +enum transaction_update_type {
> +       UPDATE_SHA1 = 0,

indent with SP?

Unlike an array initialisation, e.g.

	int foo[] = { 1,2,3,4,5, };

some compilers we support complain if enum definition ends with a
trailing comma.